Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sky130 plugin fixes #740

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Sky130 plugin fixes #740

merged 1 commit into from
Mar 14, 2023

Conversation

nayiri-k
Copy link
Contributor

@nayiri-k nayiri-k commented Mar 14, 2023

Removed source.cdl file from sky130 plugin because it is unnecessary for LVS and throws an error during LVS when the NDA path is not valid.
Also updated the tech json generation python script to generate the updated sky130.tech.json.
Already tested in (chipyard) CI and rtl-to-gds flow works.

Related PRs / Issues

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • Change to core Hammer
  • Change to a Hammer plugin
  • Other

Contributor Checklist:

  • Did you set master as the base branch?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
  • (If applicable) Did you add a unit test demonstrating the PR?
  • (If applicable) Did you run this through the e2e integration tests?
  • (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

@harrisonliew harrisonliew added this pull request to the merge queue Mar 14, 2023
Merged via the queue into master with commit d60afc0 Mar 14, 2023
@harrisonliew harrisonliew deleted the sky130fix branch March 14, 2023 17:43
harrisonliew added a commit that referenced this pull request Mar 20, 2023
harrisonliew added a commit that referenced this pull request Mar 20, 2023
* merge synopsys and cadence plugins into hammer

* get e2e tests working with asap7 on a machines

* add ICV link to docs

* incorporate genus retiming commit

* incorporate genus ILM blackboxes commit

* fix type error

* add defines for sky130 post-syn sim

* Update keys for sky130 at BWRC used for #740

* -top should be optional (#34)

* extraneous type:ignores with local mypy

* Revert "extraneous type:ignores with local mypy"

This reverts commit b0f5f95.

* openroad at bwrc moved to common location

---------

Co-authored-by: Harrison Liew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants