Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retiming #89

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Retiming #89

merged 3 commits into from
Feb 28, 2023

Conversation

dpgrubb13
Copy link
Contributor

Implements the retiming interface by adding the retime_modules step to the Genus plugin.

harrisonliew
harrisonliew approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@harrisonliew harrisonliew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this step is so simple/optional, should the insertion of the step be dependent on whether there are modules to retime? This would avoid an extra checkpoint database write when not necessary. LGTM otherwise.

@harrisonliew harrisonliew merged commit 777e28a into master Feb 28, 2023
@harrisonliew harrisonliew deleted the retiming branch February 28, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrisonliew harrisonliew harrisonliew approved these changes

@kenhoberkeley kenhoberkeley Awaiting requested review from kenhoberkeley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpgrubb13 @harrisonliew