This repository was archived by the owner on Aug 19, 2024. It is now read-only.
Remove Icarus debug messages #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like the CI is having some network issues. |
What happened is that we now disallow warnings and Chisel just added a new deprecation warning. I will make a PR to fix that shortly, then you can rebase on |
ekiwi
approved these changes
Jan 11, 2023
| @@ -91,6 +91,7 @@ abstract class PeekPokeCompliance(sim: Simulator, tag: Tag = DefaultTag) extends | |||
| if(res != values) { dut.finish() } | |||
| assert(res == values, s"width = $w") | |||
| } | |||
| dut.finish() | |||
|
OK, so we are waiting for: #608 to be merged, then you can rebase. |
|
@pineapplehunter Once you rebase on |
When using Icarus backend there was many debug messages that was not needed. I changed it to not output anything normally but show debug messages when "SimulatorDebugAnnotation" is set, like the Verilator backend. By the way I found that some tests in `PeekPokeCompliance` had not properly finished the dut. it was causing the simulator to keep running after the test finished.
|
Rebased! |
|
Awesome. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Icarus backend there was many debug messages that was not needed. I changed it to not output anything normally but show debug messages when
SimulatorDebugAnnotationis set, like the Verilator backend.By the way I found that some tests in
PeekPokeCompliancehad not properly finished the dut. it was causing the simulator to keep running after the test finished.