This repository has been archived by the owner on Apr 20, 2024. It is now read-only.
Clean up the assembly process #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump version so it's in step with Chisel3 3.5 - Avoid error on duplicate classes - put jar in utils/bin, the same way that firrtl does assembly - add calling script ./utils/bin/macro_compiler.sh
|
Is there supposed to be a script added (according to the PR description)? |
|
I don't think CY currently uses this JAR, so is the point to make it this easier to use when we move to a published version of this repo? |
|
I haven't bumped and tested in chipyard. I'll give that a try, but barstools master is now on chisel 3.5-snapshot, I think that might be a problem |
|
Not sure about the script added. I was just flushing the assembly out a bit with the firrtl convention for providing a script to run the assembled jar. I don't think CY uses this at all. The assembly process looks like @edwardcwang added it. I think assembly jars are nice because they spin up way faster than sbt, so ultimately it would be good to get chipyard to use them where feasible. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assembly of a jar using main from MacroCompiler is fixed.
I don't see anywhere where this is used. So I'm not sure what may be affected by the placement
of the generated jar in ./utils/bin.