Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(.github/workflows): UDENG-5763-Add GitHub Actions workflows for code checks, QA, and git checks #4

Merged
merged 9 commits into from
Jan 15, 2025

Conversation

hk21702
Copy link
Collaborator

@hk21702 hk21702 commented Jan 14, 2025

Implement QA & sanity checks workflow
Ensure multi-platform checks (Ubuntu 24.04, Windows 2022, Macos-13, Macos-14)

  • Go code sanity checks with golangci
  • Go tests with coverage and race condition checks
    • Use gotestfmt
  • Use Codecov
  • Upload artifacts

Todo: Add CODECOV_TOKEN secret

Add Git Checks workflow


UDENG-5763

@hk21702 hk21702 added the enhancement New feature or request label Jan 14, 2025
@hk21702 hk21702 self-assigned this Jan 14, 2025
@hk21702 hk21702 force-pushed the UDENG-5763-go-qa-tests branch 5 times, most recently from d4c144d to ac43144 Compare January 14, 2025 23:08
@hk21702 hk21702 marked this pull request as ready for review January 14, 2025 23:15
@hk21702 hk21702 force-pushed the UDENG-5763-go-qa-tests branch from 877d1cb to 9029d6e Compare January 15, 2025 16:54
@hk21702 hk21702 force-pushed the UDENG-5763-go-qa-tests branch from 9029d6e to 6dc12c4 Compare January 15, 2025 17:00
Copy link
Collaborator

@Sploder12 Sploder12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few questions from me

.github/workflows/qa.yaml Outdated Show resolved Hide resolved
cmd/insights/commands/upload.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@Sploder12 Sploder12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hk21702 hk21702 merged commit 12c4732 into main Jan 15, 2025
14 checks passed
@hk21702 hk21702 deleted the UDENG-5763-go-qa-tests branch January 15, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants