Skip to content

Commit

Permalink
Update QA workflow to use 'set -euo pipefail' for improved error hand…
Browse files Browse the repository at this point in the history
…ling
  • Loading branch information
hk21702 committed Jan 15, 2025
1 parent d5a279b commit 8cf3138
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/qa.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:

- name: Prepare tests artifacts path
run: |
set -eu
set -euo pipefail
artifacts_dir=$(mktemp -d -t insights-test-artifacts-XXXXXX)
echo INSIGHTS_TEST_ARTIFACTS_PATH="${artifacts_dir}" >> $GITHUB_ENV
Expand All @@ -61,7 +61,7 @@ jobs:
env:
G_DEBUG: "fatal-criticals"
run: |
set -eu
set -euo pipefail
cov_dir=$(pwd)/coverage
mkdir -p ${cov_dir}/codecov ${cov_dir}/raw
Expand All @@ -74,6 +74,7 @@ jobs:
env:
GO_TESTS_TIMEOUT: 35m
run: |
set -euo pipefail
go test -json -timeout ${GO_TESTS_TIMEOUT} -race ./... | \
gotestfmt --logfile "${INSIGHTS_TEST_ARTIFACTS_PATH}/gotestfmt.race.log"
shell: bash
Expand All @@ -91,4 +92,3 @@ jobs:
with:
name: insights-${{ github.job }}-${{ matrix.test }}-${{ matrix.os }}-artifacts-${{ github.run_attempt }}
path: ${{ env.INSIGHTS_TEST_ARTIFACTS_PATH }}

0 comments on commit 8cf3138

Please sign in to comment.