Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename package "cache" to "db" #775

Closed
wants to merge 3 commits into from
Closed

Rename package "cache" to "db" #775

wants to merge 3 commits into from

Conversation

adombeck
Copy link
Contributor

@adombeck adombeck commented Feb 4, 2025

We don't use our database as a cache anymore. It's time to reflect this in the package name.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Changes done by running:

   git rm "internal/*/testdata/golden/*"
   TESTS_UPDATE_GOLDEN=1 go test ./internal/...
   git add -A

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We don't use our database as a cache anymore. It's time to reflect this
in the package name.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@adombeck adombeck marked this pull request as ready for review February 7, 2025 13:30
@adombeck adombeck requested a review from a team as a code owner February 7, 2025 13:30
@adombeck adombeck requested a review from didrocks February 10, 2025 13:26
@adombeck
Copy link
Contributor Author

This was part of #779

@adombeck adombeck closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant