Use lowercase usernames #314
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
The diffs of mismatching golden files are passed through git-delta since #207.
The ubuntu-latest label still resolves to Jammy, where git-delta is not packaged.
It's hard to figure out why authentication is denied if there is no explanation at all in the logs.
adombeck
force-pushed
the
UDENG-4518-case-insensitive-usernames
branch
from
9b653e2 to
7770282
Compare
adombeck
force-pushed
the
UDENG-4518-case-insensitive-usernames
branch
from
7770282 to
29fbea0
Compare
adombeck
commented
Jan 16, 2025
| @@ -21,13 +21,19 @@ jobs: | |||
|
|
|||
There was a problem hiding this comment.
This is a reminder to not merge this PR for at least some weeks after the respective change in authd has been released, to reduce the number of users who are impacted by a new authd-msentraid broker being installed along with an incompatible old authd.
There was a problem hiding this comment.
Maybe convert it back to draft to prevent any accident?
There was a problem hiding this comment.
I'm afraid it won't show up on the reviewers' radar then :/
There was a problem hiding this comment.
we can keep the Jira card for reference?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broker part of ubuntu/authd#723
Closes ubuntu/authd#530, ubuntu/authd#531
UDENG-4518
UDENG-4519
UDENG-5802
TODO
INITIAL_LOWERCASE_USERNAMES_VERSIONis set to the correct versionmsentraid-*tag of that version on the commit which merges main intomsentraidgoogle-*tag of that version on the commit which merges main intogoogle