-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Switch from dconf to gschema-overrides #1714
Open
fiftydinar
wants to merge
13
commits into
ublue-os:testing
Choose a base branch
from
fiftydinar:from-dconf-to-gschema
base: testing
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I finished dconf loading support from gschemas. So only testing is needed now. |
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
enhancement
New feature or request
labels
Sep 29, 2024
KyleGospo
previously approved these changes
Sep 29, 2024
KyleGospo
approved these changes
Sep 29, 2024
auto-merge was automatically disabled
October 1, 2024 18:31
Head branch was pushed to by a user without write access
See Bluefin's PR for more details: ublue-os/bluefin#1716
Converts gschema overrides to dconfs
dconf doesn't support loading more config at once, so do for/done loop.
fiftydinar
force-pushed
the
from-dconf-to-gschema
branch
from
October 2, 2024 08:51
1d00536
to
8c58468
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Bluefin's PR for more details:
ublue-os/bluefin#1716
It's in draft just for testing
I see that you load dconf in some scripts, I'll have to see how to solve this with gschema-overrides