Feat: Descriptive Error Message

[Steveantor]

Resolves #21

[0x4007]

Do you have a permit link I can test this with?

[Steveantor]

Do you have a permit link I can test this with?

here's one
permit-url
@pavlovcik

[ubiquibot]

Available commands

- /assign: Assign the origin sender to the issue automatically.
        ex: /assign

- /wallet <WALLET_ADDRESS | ENS_NAME>: Register the hunter's wallet address.
	ex1: /wallet 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266
	ex2: /wallet vitalik.eth

@Steveantor

[0x4007]

I just realized I can use the one logged in the yarn start command

http://localhost:8080/?claim=eyJwZXJtaXQiOnsicGVybWl0dGVkIjp7InRva2VuIjoiMHg2QjE3NTQ3NEU4OTA5NEM0NERhOThiOTU0RWVkZUFDNDk1MjcxZDBGIiwiYW1vdW50IjoiMTAwMDAwMDAwMDAwMDAwMDAwMCJ9LCJub25jZSI6IjY5MTg1MDU5NjQxMDM4OTUwODY4NDU5MTA2NTgyMzExODg0MjQ5MjM4NTkyMDcwOTQ4ODE2Nzk0ODgwNDg0ODQwODM2ODA2OTUzMDMxIiwiZGVhZGxpbmUiOiIxMTU3OTIwODkyMzczMTYxOTU0MjM1NzA5ODUwMDg2ODc5MDc4NTMyNjk5ODQ2NjU2NDA1NjQwMzk0NTc1ODQwMDc5MTMxMjk2Mzk5MzUifSwidHJhbnNmZXJEZXRhaWxzIjp7InRvIjoiMHg0MDA3Q0UyMDgzYzdGM0UxODA5N2FlQjNBMzliYjhlQzE0OWEzNDFkIiwicmVxdWVzdGVkQW1vdW50IjoiMTAwMDAwMDAwMDAwMDAwMDAwMCJ9LCJvd25lciI6IjB4Zjg3Y2E0NTgzQzc5MjIxMmU1MjcyMGQxMjdFN0UwQTM4QjgxOGFEMSIsInNpZ25hdHVyZSI6IjB4MzUwMmI4YWMzZTdjOGYxYzUyMzM3MmFlNWY5YjVhZjI2Zjk2ZjdiZTBjNmQzMmE4M2IzYmEzNjg1NDZkMGFjNTJiZDE0NDExYjk0OTBkMDg0NjJhZjAxYzM2NTZhOTdkYmRiNWQ3MDhhZjFmMjc0NGMxZTk1YmZjMWI0NmY5N2QxYyJ9

[0x4007]

This notation is not clear to me. What is the "$800.0"

[Steveantor]

This notation is not clear to me. What is the "$800.0"

balance and approval @pavlovcik

[ubiquibot]

Available commands

- /assign: Assign the origin sender to the issue automatically.
        ex: /assign

- /wallet <WALLET_ADDRESS | ENS_NAME>: Register the hunter's wallet address.
	ex1: /wallet 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266
	ex2: /wallet vitalik.eth

@Steveantor

[0x4007]

I need to think about the design to convey this information clearly and concisely. I feel like this should be in the "more details" ( ? ) dropdown details section.

I do like your implementation here, but the original bounty was supposed to be simpler: writing in plain english the issue when the errors dump into the DOM.

[0x4007]

I mocked up a new design can you implement the following:

[Steveantor]

I mocked up a new design can you implement the following:

okay, I'll do and updating u here @pavlovcik

[Steveantor]

should I delete the treasury field above? @pavlovcik

[ubiquibot]

Available commands

- /assign: Assign the origin sender to the issue automatically.
        ex: /assign

- /wallet <WALLET_ADDRESS | ENS_NAME>: Register the hunter's wallet address.
	ex1: /wallet 0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266
	ex2: /wallet vitalik.eth

@Steveantor

[0x4007]

Well to clarify, we should still have the plain english error when the claim fails (like when the raw MetaMask JSON RPC error dumps in the red monospace text on the DOM.) Please show both e.g:

• plain english error
• raw JSON RPC MetaMask error

However what you already implemented here could be technically considered as a separate bounty.

Yes you should remove the treasury field.

[Steveantor]

upped

[0x4007]

From https://github.com/ubiquity/pay.ubq.fi
 ! [rejected]        refs/pull/23/head -> Steveantor/main  (non-fast-forward)
failed to run git: exit status 1

Git won't let me test this lol maybe you can rebase to main head

[Steveantor]

From https://github.com/ubiquity/pay.ubq.fi
 ! [rejected]        refs/pull/23/head -> Steveantor/main  (non-fast-forward)
failed to run git: exit status 1

Git won't let me test this lol maybe you can rebase to main head

rebased @pavlovcik

[0x4007]

Not sure why I'm getting the same error.

[Steveantor]

Not sure why I'm getting the same error.

might be your git client having issues

[0x4007]

Looks good.

---

Strangely enough it crashes on Safari right at the function execution but technically that's not in scope of the bounty. But still concerning that there's inconsistencies with Safari and Chrome for a simple promise.

[Error] Unhandled Promise Rejection: Error: missing provider (argument="provider", value=undefined, code=INVALID_ARGUMENT, version=providers/5.7.2)

	(anonymous function) (app.ts:8)