Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/UI fixes icon changes #27

Merged
merged 10 commits into from
Sep 10, 2024
Merged

Conversation

AttePeramaki
Copy link

Few icon changes/additions
Font change
logo change on admin panel

Copy link
Member

@jlaamanen jlaamanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💎

import React from 'react';
import SvgIcon, { SvgIconProps } from '@mui/material/SvgIcon';

export default function DocumentCopyIcon(props: SvgIconProps) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] FYI, usually it's better to use named exports rather than default exports, because it makes it easier to refactor and auto-import the components.

But it seems that all the icons are already using default exports, so maybe it's not worth the effort to change this now...

@AttePeramaki AttePeramaki merged commit e9724fa into develop Sep 10, 2024
2 checks passed
@AttePeramaki AttePeramaki deleted the feature/ui-fixes-icon-changes branch September 10, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants