Feature/ubigufy #21
Feature/ubigufy #21
Conversation
| @@ -65,20 +66,21 @@ export default function SurveyListItem(props: Props) { | |||
| }/${survey.name}`; | |||
| }, [survey.name]); | |||
|
|
|||
| const cardStyle = survey.isPublished | |||
There was a problem hiding this comment.
Inline styles are usually bad practice, unless it's the only choice. In this case we can rely on MUI's theming and add a new class inside makeStyles, e.g. publishedCard: { ... }.
The easiest way to apply multiple conditional class names is to use the clsx utility library. It should already be installed as a 3rd party dependency, but feel free to npm install it to this project as well:
import clsx from 'clsx';
clsx(loading && classes.loading, survey.isPublished && classes.publishedCard)| @@ -0,0 +1,40 @@ | |||
| import React from 'react'; | |||
| import SvgIcon, { SvgIconProps } from '@mui/material/SvgIcon'; | |||
| // TODO: fills... | |||
There was a problem hiding this comment.
[nit] forgotten temporary comments in this file?
| /> | ||
| </g> | ||
| <defs> | ||
| <clipPath id="clip0_3398_1868"> |
There was a problem hiding this comment.
This is the clip path I was talking about. Maybe you should check if multiple MailIcons on the same page work with this? Otherwise I guess it should be removed, but not sure if that would break this icon... 🤔
client/src/themes/admin.ts
Outdated
|
|
||
| export let theme = createTheme( | ||
| { | ||
| components: { | ||
| ...surveyCardOverrides, | ||
| //...textOverrides, |
There was a problem hiding this comment.
[nit] forgotten commented out code in this file?
client/src/themes/common.ts
Outdated
| } | ||
| }; | ||
|
|
||
| // |
client/src/themes/survey.ts
Outdated
| ...buttonOverrides, | ||
| ...inputOverrides, | ||
| ...stepperOverrides, | ||
| ...textOverrides, | ||
| }, | ||
| } /* |
There was a problem hiding this comment.
[nit] forgotten commented out code?
Added Icons from Material to Ubilibrary