Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade headless-ui to v2 #134

Merged
merged 6 commits into from
Sep 20, 2024
Merged

Upgrade headless-ui to v2 #134

merged 6 commits into from
Sep 20, 2024

Conversation

takanorip
Copy link
Contributor

Changes

  • Upgrade headless-ui to v2
  • Fix DialogPanel

Check

  • Browser verification (minimum) Android Chrome/iOS Safari(375px-)
  • CSS not affected by inheritance
  • Layout does not break even if there is an overflow
  • Layout does not break when wraps
  • Added new Component
    • Added data-* prop and id prop
  • Updated Ubie Vitals or Added an update issue(if needed)

@takanorip takanorip self-assigned this Sep 14, 2024
@8845musign 8845musign mentioned this pull request Sep 19, 2024
7 tasks
package.json Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏
Dialog.Title → DialogTitle

Test
</TextArea>,
);
render(<TextArea name="test" defaultValue="test" ref={ref} />);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@8845musign 8845musign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the focus management. It's working well.
Please merge after fixing the minor points!

package.json Outdated
"tsup": "^8.2.4",
"typescript": "5.6.2",
"vite": "^5.4.5",
"vitest": "^2.1.1"
},
"peerDependencies": {
"@headlessui/react": ">1.7.0 <2.0.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be limited to 2.0 or higher

Copy link
Collaborator

@8845musign 8845musign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@takanorip takanorip merged commit 6516d11 into main Sep 20, 2024
2 checks passed
@takanorip takanorip deleted the upgrade-headlessui branch September 20, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants