Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Icon size is affected by context #132

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Fix: Icon size is affected by context #132

merged 1 commit into from
Sep 13, 2024

Conversation

8845musign
Copy link
Collaborator

Changes

  • The unit of size of the icon was em
  • The size of the icon changes depending on the font-size of the location where it is placed
  • Correction to rem

Check

  • Browser verification (minimum) Android Chrome/iOS Safari(375px-)
  • CSS not affected by inheritance
  • Layout does not break even if there is an overflow
  • Layout does not break when wraps
  • Added new Component
    • Added data-* prop and id prop
  • Updated Ubie Vitals or Added an update issue(if needed)

@8845musign 8845musign self-assigned this Sep 13, 2024
@takanorip takanorip merged commit db1fbee into ubie-oss:main Sep 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takanorip takanorip takanorip approved these changes

Assignees

@8845musign 8845musign

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@8845musign @takanorip