Support ref and element attribute #124
Closed
+1,497
−926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
receive a ref
8845musign
force-pushed
the
support-ref-and-element-attribute
branch
from
827d151
to
b802964
Compare
8845musign
commented
Aug 8, 2024
| /** | ||
| * ラッパーであるdetails要素に付与するネイティブ要素の`id`属性。ページで固有のIDを指定 | ||
| */ | ||
| id?: string; |
There was a problem hiding this comment.
The prop of the native element, which we had dared to define for the sake of adding explanation, is deleted.
| } else { | ||
| return <CenterCopmonent {...props}>{children}</CenterCopmonent>; | ||
| const Element = CenterComponent as ElementType; |
There was a problem hiding this comment.
It is obvious that it is already the remaining ElementType here, since it is checked if it is a ReactElement above, but the type narrowing did not work
|
|
||
| if (typeof (Element as unknown) !== 'string') { | ||
| // eslint-disable-next-line no-console | ||
| console.error('as prop only supports native elements or Box.'); |
There was a problem hiding this comment.
Assuming that a specification like as={Stack} is made.
I can throw an error, but I don't want the application to stop working if it falls under the existing code
|
Box has not yet been fixed. |
|
Closed due to no immediate needs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Check