Skip to content

added blocking reviewers #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
go-version: ['1.15', '1.16']
go-version: ['1.17', '1.18']
node-version: ['v8.12.0'] # version Travis was using
env:
GOPATH: ${{ github.workspace }}
Expand Down
2 changes: 2 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -285,10 +285,12 @@ jenkins-install:
.PHONY: jenkins-test
jenkins-test:
make check-generate
make fix-licence
make lint
make test-only

.PHONY: jenkins
jenkins:
$(MAKE) jenkins-install
$(MAKE) jenkins-test

4 changes: 3 additions & 1 deletion codegen/module.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2022 Uber Technologies, Inc.
// Copyright (c) 2023 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
Expand Down Expand Up @@ -1844,6 +1844,8 @@ type ClassConfigBase struct {
Owner string `yaml:"owner,omitempty"`
// SelectiveBuilding allows the module to be built with subset of dependencies
SelectiveBuilding bool `yaml:"selectiveBuilding,omitempty" json:"selectiveBuilding"`
// BlockingReviewes contains the list of blocking reviewers for the particular module
BlockingReviewers []string `yaml:"blockingReviewers,omitempty" json:"blockingReviewers"`
}

// ClassConfig maps onto a YAML configuration for a class type
Expand Down
3 changes: 2 additions & 1 deletion codegen/test-service/endpoints/health/endpoint-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@
]
},
"name": "health",
"type": "http"
"type": "http",
"blockingReviewers": ["[email protected]", "[email protected]"]
}