logging for conflicting url paths #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekparwal
force-pushed
the
logging_fix_router
branch
from
f14d4bb to
699e6af
Compare
abhishekparwal
force-pushed
the
logging_fix_router
branch
from
699e6af to
c1b2eec
Compare
tejaswiagarwal
approved these changes
Jun 3, 2020
rpatali
reviewed
Jun 3, 2020
|
|
||
| // Error returns the error string | ||
| func (e *urlFailure) Error() string { | ||
| return fmt.Sprintf("panic: path: %q method: %q conflicts with an existing path", e.url, e.method) |
There was a problem hiding this comment.
don't think panic should be part of the message itself.
There was a problem hiding this comment.
acked. we can improve message in future diff.
…er gives this lower coverage error
rpatali
reviewed
Jun 3, 2020
| @@ -128,7 +128,7 @@ cat ./coverage/istanbul.json | jq '[ | |||
| ] | from_entries' > ./coverage/istanbul-runtime.json | |||
|
|
|||
| echo "Checking code coverage for runtime folder" | |||
| ./node_modules/.bin/istanbul check-coverage --statements 99.92 \ | |||
| ./node_modules/.bin/istanbul check-coverage --statements 99.85 \ | |||
There was a problem hiding this comment.
I'm sure there are tests for duplicate URL case, I would have not expected the coverage to drop. If this is not the case, we should add coverage instead of changing this.
There was a problem hiding this comment.
There was a problem hiding this comment.
and see the previous run of this, where test fails and you can see it didn't decrease for this package.
smb158
pushed a commit
that referenced
this pull request
Jun 12, 2020
* logging for conflicting url paths * coverage didnt increase for affected path, however touching this folder gives this lower coverage error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.