Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor more code to adhere to a stricter set of warnings #439

Closed
wants to merge 2 commits into from

Conversation

VivekPanyam
Copy link
Collaborator

@VivekPanyam VivekPanyam commented Sep 19, 2020

Summary:

(will add summary before requesting review)

Test Plan:

CI +

./build/build.sh --config ci (which treats warnings as errors)

@codecov
Copy link

codecov bot commented Sep 19, 2020

Codecov Report

Merging #439 into cc_warnings will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           cc_warnings     #439   +/-   ##
============================================
  Coverage        89.30%   89.30%           
============================================
  Files              101      102    +1     
  Lines             5536     5537    +1     
============================================
+ Hits              4944     4945    +1     
  Misses             592      592           
Impacted Files Coverage Δ
source/neuropod/bindings/c/c_api.cc 100.00% <ø> (ø)
...java/src/main/native/com_uber_neuropod_Neuropod.cc 83.81% <ø> (ø)
...d/bindings/java/src/main/native/jclass_register.cc 76.81% <ø> (ø)
source/neuropod/internal/backend_registration.hh 100.00% <ø> (ø)
...urce/neuropod/multiprocess/mq/ipc_message_queue.hh 100.00% <ø> (ø)
...neuropod/multiprocess/mq/ipc_message_queue_impl.hh 91.11% <ø> (ø)
...ource/neuropod/multiprocess/multiprocess_worker.cc 95.45% <ø> (ø)
source/neuropod/neuropod.cc 97.14% <ø> (ø)
source/neuropod/backends/neuropod_backend.cc 96.72% <100.00%> (ø)
source/neuropod/backends/tensorflow/tf_backend.cc 90.94% <100.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ec9f8b...1cc25c4. Read the comment docs.

Base automatically changed from cc_warnings to master September 21, 2020 22:39
@VivekPanyam
Copy link
Collaborator Author

Superseded by #442, #443, and #444

@VivekPanyam VivekPanyam closed this Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant