Add Creatable api. Remove @Dependencies.
#131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leland-Takamine
requested review from
kurtisnelson,
tyvsmith,
ugonna and
oliviernotteghem
Leland-Takamine
force-pushed
the
creatable
branch
4 times, most recently
from
7ec36ef to
1fd6a0b
Compare
kurtisnelson
approved these changes
Sep 27, 2019
ugonna
approved these changes
Sep 27, 2019
| @@ -24,7 +24,6 @@ import org.junit.Test | |||
| import javax.annotation.processing.AbstractProcessor | |||
| import javax.annotation.processing.RoundEnvironment | |||
| import javax.lang.model.element.TypeElement | |||
| import javax.lang.model.type.TypeKind | |||
|
|
|||
| class CompilerClassTest { | |||
There was a problem hiding this comment.
Does it make sense to also add a testSupertypeMultipleInterfaces() for IrClass.supertypes?
package test;
interface Baz {}
interface Bar {}
class Foo implements Bar, Baz {}Same in IntellijClassTest. Especially since you iterate through them in motif.model.Dependencies.
There was a problem hiding this comment.
Good call will add.
| findCreatableSuperinterface(superinterface)?.let { return it } | ||
| } | ||
|
|
||
| return null |
There was a problem hiding this comment.
Is there a test case for no Creatable parent? Doesn't seem so from this PR alone.
There was a problem hiding this comment.
There are but I'll add one that tests this case explicitly.
Leland-Takamine
force-pushed
the
creatable
branch
8 times, most recently
from
5f3d376 to
d27718c
Compare
Leland-Takamine
force-pushed
the
creatable
branch
from
d27718c to
90f6bf3
Compare
Leland-Takamine
force-pushed
the
creatable
branch
6 times, most recently
from
423d3b5 to
6485ab2
Compare
Leland-Takamine
force-pushed
the
creatable
branch
from
6485ab2 to
8de6db6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First half of #125
Replace
@DependenciesAPI withCreatable<D>. A follow up PR will add theScopeFactoryAPI.