Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARM external linker must be gold (issue #15696), but is not: zig ld 0.11.0 #122

Open
farcop opened this issue Sep 30, 2023 · 9 comments
Open

ARM external linker must be gold (issue #15696), but is not: zig ld 0.11.0 #122

farcop opened this issue Sep 30, 2023 · 9 comments
Labels
upstream this is caused by an upstream issue

Comments

@farcop
Copy link

farcop commented Sep 30, 2023

After upgrade on https://github.com/uber/hermetic_cc_toolchain/releases/tag/v2.1.2
On linux/amd64 VM I get error when trying to build go_binary.

2023/09/30 07:07:20 ARM external linker must be gold (issue #15696), but is not: zig ld 0.11.0
link: error running subcommand external/go_sdk/pkg/tool/linux_amd64/link: exit status 1

golang/go#15696

Rolled back to the 2.0.0 to workaround this issue.
@farcop
Copy link
Author

farcop commented Oct 2, 2023 •
edited
Loading

Tested with

register_toolchains(
    "@zig_sdk//toolchain:linux_amd64_gnu.2.31",
    "@zig_sdk//toolchain:linux_arm64_gnu.2.31",
)

and with 2.34.

Debug output:

ERROR: /home/kublr/kublr/cluster-controller/BUILD.bazel:27:10: GoLink cluster-controller/cluster-controller failed: (Exit 1): linux-sandbox failed: error executing command 
  (cd /home/kublr/.cache/bazel/_bazel_kublr/69fb4c52c15303cc4e23e5352527edec/sandbox/linux-sandbox/1/execroot/kublr && \
  exec env - \
    CGO_ENABLED=1 \
    GOARCH=arm64 \
    GOEXPERIMENT=nocoverageredesign \
    GOOS=linux \
    GOPATH='' \
    GOROOT=bazel-out/k8-fastbuild-ST-29c7f66a8f11/bin/external/io_bazel_rules_go/stdlib_ \
    GOROOT_FINAL=GOROOT \
    PATH=external/zig_sdk/tools:external/zig_sdk/tools/aarch64-linux-gnu.2.34:/bin:/usr/bin \
    TMPDIR=/tmp \
  /home/kublr/.cache/bazel/_bazel_kublr/install/a09dbb90c658248f08f9aa0eba11997d/linux-sandbox -t 15 -w /home/kublr/.cache/bazel/_bazel_kublr/69fb4c52c15303cc4e23e5352527edec/sandbox/linux-sandbox/1/execroot/kublr -w /tmp -w /dev/shm -S /home/kublr/.cache/bazel/_bazel_kublr/69fb4c52c15303cc4e23e5352527edec/sandbox/linux-sandbox/1/stats.out -D -- bazel-out/k8-opt-exec-2B5CBBC6-ST-e846b08c7501/bin/external/go_sdk/builder_reset/builder '-param=bazel-out/k8-fastbuild-ST-49c02b6fcfac/bin/cluster-controller/cluster-controller-0.params' -- -extld external/zig_sdk/tools/aarch64-linux-gnu.2.34/c++ -X 'src.kublr.io/kublr/common/pkg/version.version=1.28.0-alpha.0' '-buildid=redacted' -s -w -extldflags '-fno-lto -fsanitize-undefined-strip-path-components=-1')

@motiejus
Copy link
Collaborator

Which Go/Zig version do you use with this? Can this be reproduced with tests of hermetic_cc_toolchain?

@farcop farcop mentioned this issue Oct 10, 2023
Closed
@farcop
Copy link
Author

farcop commented Oct 10, 2023

@motiejus
go 1.20
zig is default toolchain version in v2.1.2

which test I should run?

@motiejus
Copy link
Collaborator

@motiejus go 1.20 zig is default toolchain version in v2.1.2

which test I should run?

The point is we need to be able to reproduce the failure. Your report does not include a test case, so let's come up with one.

We have a bunch of tests in hermetic_cc_toolchain, which are currently green. Perhaps it would be easy to change one that reproduces this failure?

@farcop
Copy link
Author

farcop commented Oct 24, 2023

I can only confirm that error is in multi architecture image transformation written just like https://github.com/bazel-contrib/rules_oci/blob/main/examples/multi_arch/BUILD.bazel#L19-L26
I cant publish whole code example but the same code works well with 2.0.0 release of hermetic_cc_toolchain.

lbcjbb added a commit to lbcjbb/hermetic_cc_toolchain that referenced this issue Oct 27, 2023
@lbcjbb
tests: add test on Go binary for Linux ARM64
d82ea2d 
Add test to try to cross compile a Go binary for Linux ARM64
with CGO, requiring `$CC -fuse-ld=gold -Wl,--version`
to return the string `GNU gold`.

Using Go *1.20.4*:

```
link: ARM external linker must be gold (issue #15696), but is not: zig ld 0.11.0
```

Using Go *1.21.3*:

```
link: ARM64 external linker must be gold (issue #15696, 22040), but is not: zig ld 0.11.0
```

For an unknown reason, importing the `plugin` library force
the Go toolchain to pass in the code [1] to link the binary.
Enable CGO and cross compile (GOOS=linux GOARCH=arm64) is not
sufficient.

See https://go.dev/issue/15696 and https://go.dev/issue/22040 for more
details.

Issue: uber#122

[1]: https://go.googlesource.com/go/+/refs/heads/master/src/cmd/link/internal/ld/lib.go#1628
@lbcjbb lbcjbb mentioned this issue Oct 27, 2023
Closed
@lbcjbb
Copy link

lbcjbb commented Oct 27, 2023

I've just added a test to reproduce this failure in #129

@farcop
Copy link
Author

farcop commented Oct 27, 2023

@lbcjbb Thank you. Much appreciated.

lbcjbb added a commit to lbcjbb/hermetic_cc_toolchain that referenced this issue Oct 27, 2023
@lbcjbb
tests: add test on Go binary for Linux ARM64
2b98691 
Add test to try to cross compile a Go binary for Linux ARM64
with CGO, requiring `$CC -fuse-ld=gold -Wl,--version`
to return the string `GNU gold`.

Using Go *1.20.4*:

```
link: ARM external linker must be gold (issue #15696), but is not: zig ld 0.11.0
```

Using Go *1.21.3*:

```
link: ARM64 external linker must be gold (issue #15696, 22040), but is not: zig ld 0.11.0
```

For an unknown reason, importing the `plugin` library force
the Go toolchain to pass in the code [1] to link the binary.
Enable CGO and cross compile (GOOS=linux GOARCH=arm64) is not
sufficient.

See https://go.dev/issue/15696 and https://go.dev/issue/22040 for more
details.

Issue: uber#122

[1]: https://go.googlesource.com/go/+/refs/heads/master/src/cmd/link/internal/ld/lib.go#1628
lbcjbb added a commit to lbcjbb/hermetic_cc_toolchain that referenced this issue Oct 27, 2023
@lbcjbb
tests: add test for the build of a Go plugin for Linux ARM64
67efa27 
Add test to try to cross compile a Go plugin for Linux ARM64,
requiring the command `$CC -fuse-ld=gold -Wl,--version`, executed
by the Go toolchain, to return the string `GNU gold`.

Using Go *1.20.4*:

```
link: ARM external linker must be gold (issue #15696), but is not: zig ld 0.11.0
```

Using Go *1.21.3*:

```
link: ARM64 external linker must be gold (issue #15696, 22040), but is not: zig ld 0.11.0
```

Building a Go `plugin` library force the Go toolchain
to pass in the code [1] to link the binary.
Enable CGO and cross compile (GOOS=linux GOARCH=arm64) is not
sufficient.

See https://go.dev/issue/15696 and https://go.dev/issue/22040 for more
details.

Issue: uber#122

[1]: https://go.googlesource.com/go/+/8c92897e15d15fbc664cd5a05132ce800cf4017f/src/cmd/link/internal/ld/lib.go#1628
lbcjbb added a commit to lbcjbb/hermetic_cc_toolchain that referenced this issue Oct 27, 2023
@lbcjbb
zip-wrapper: fix compile of Go plugin for Linux ARM64
56c4e1e 
Fixes uber#122
@lbcjbb
Copy link

lbcjbb commented Oct 27, 2023

56c4e1e should fix this issue now.

@linzhp
Copy link
Contributor

linzhp commented Nov 30, 2023 •
edited
Loading

I think this is due to a hack in Go linker.

Either this or this will fix it. I would prefer patching Go linker with one of these patches and report the success or failure on golang/go#22040, instead of putting another hack on hermetic_cc_toolchain to cheat Go linker.

@motiejus motiejus added the upstream this is caused by an upstream issue label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upstream this is caused by an upstream issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix compile of Go plugin or shared library for Linux ARM64 lbcjbb/hermetic_cc_toolchain
4 participants
@linzhp @motiejus @farcop @lbcjbb