Add test for cellsToLinkedMultipolygon leak #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
isaacbrodsky
force-pushed
the
cells-to-linked-multipolygon-leak
branch
from
3bda16a
to
82bd644
Compare
dfellis
approved these changes
Sep 5, 2022
nrabinowitz
approved these changes
Sep 6, 2022
| // We assume that the input is a single polygon with loops; | ||
| // if it has multiple polygons, don't touch it | ||
| if (root->next) { | ||
| return NORMALIZATION_ERR_MULTIPLE_POLYGONS; |
There was a problem hiding this comment.
Should we make new H3Error codes here? I'm not sure if it matters for the end user at this point, but this change drops information about the source of the error.
There was a problem hiding this comment.
We could - that information was not exposed to the user before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test #669.