Bug fixes for directed edge #559
Conversation
| @@ -329,6 +329,19 @@ SUITE(gridDisk) { | |||
| t_assert(out == origin, "Moving to self goes to self"); | |||
| } | |||
|
|
|||
| TEST(h3NeighborRotations_invalid) { | |||
| // This is undefined behavior, but it's helpful for it to make sense. | |||
| H3Index origin = 0x811d7ffffffffffL; | |||
There was a problem hiding this comment.
Anything special about this particular H3 index?
There was a problem hiding this comment.
No - I just needed a known good index as I wanted the only rotations to be under test.
There was a problem hiding this comment.
For my info, is there any difference between indexes with the L suffix or without? Should we be consistent?
There was a problem hiding this comment.
All valid H3 indexes would only be valid integers as 64 bit, so no I don't believe so.
| @@ -329,6 +329,19 @@ SUITE(gridDisk) { | |||
| t_assert(out == origin, "Moving to self goes to self"); | |||
| } | |||
|
|
|||
| TEST(h3NeighborRotations_invalid) { | |||
| // This is undefined behavior, but it's helpful for it to make sense. | |||
| H3Index origin = 0x811d7ffffffffffL; | |||
There was a problem hiding this comment.
For my info, is there any difference between indexes with the L suffix or without? Should we be consistent?
| @@ -335,6 +335,9 @@ H3Error h3NeighborRotations(H3Index origin, Direction dir, int *rotations, | |||
| H3Index *out) { | |||
| H3Index current = origin; | |||
|
|
|||
| if (dir < CENTER_DIGIT || dir >= INVALID_DIGIT) { | |||
There was a problem hiding this comment.
For my info, what does CENTER_DIGIT even do? Returns the current index?
There was a problem hiding this comment.
Yes, that is my expectation
Based upon #553. This updates the tests with some cases found via fuzzing to the test suite.