-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trying out adding benchmarks to github actions CI #524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I can see the benchmark output in the checks. Would be awesome if we had some coveralls-style way of reporting this, but 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there's some way we can collect and monitor benchmark performance, like https://github.com/marketplace/actions/continuous-benchmark or https://werat.dev/blog/running-benchmarks-for-pull-requests-via-github-actions/?
- name: Build | ||
run: | | ||
cd build | ||
make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now we don't have a way to indicate building just the benchmarks without running them in the same invocation. If the build part needs to be sped up we could turn off some other build options (building tests, etc.) in CMake, or add a "build without run" option for benchmarks.
Co-authored-by: Isaac Brodsky <[email protected]>
That'd be nice! I'm deferring it to #530 just so I can get this landed, finally 😄 |
As worried about in #523.
My GH Actions knowledge is rusty, so more than happy if anyone has suggestions to clean up the
test-bench.yml
.