change H3_HEXAGON_MODE to H3_CELL_MODE #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajfriend
commented
Jul 5, 2021
Comment on lines
80
to
84
| /** H3 index modes */ | ||
| #define H3_HEXAGON_MODE 1 | ||
| #define H3_CELL_MODE 1 | ||
| #define H3_DIRECTEDEDGE_MODE 2 | ||
| #define H3_EDGE_MODE 3 | ||
| #define H3_VERTEX_MODE 4 |
There was a problem hiding this comment.
Should these maybe be exposed in h3api.h?
There was a problem hiding this comment.
Are these returned or accepted by the API anywhere? Definitely if so.
nrabinowitz
approved these changes
Jul 12, 2021
isaacbrodsky
approved these changes
Jul 12, 2021
Comment on lines
80
to
84
| /** H3 index modes */ | ||
| #define H3_HEXAGON_MODE 1 | ||
| #define H3_CELL_MODE 1 | ||
| #define H3_DIRECTEDEDGE_MODE 2 | ||
| #define H3_EDGE_MODE 3 | ||
| #define H3_VERTEX_MODE 4 |
There was a problem hiding this comment.
Are these returned or accepted by the API anywhere? Definitely if so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
H3_CELL_MODEis the more correct name due to pentagons.