Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to v4.0.0-rc2 #91

Merged
merged 17 commits into from
Mar 28, 2022
Merged

Conversation

isaacbrodsky
Copy link
Collaborator

@isaacbrodsky isaacbrodsky commented Feb 18, 2022

Upgrades H3-Java to H3 core library v4.0.0 release candidate. Since this is not the final v4 release, H3-Java with v4 is also considered pre-release.

A new class, H3CoreV3, is added to act as a compatibility layer during upgrades. Because it is implemented using the v4 library underneath, care was not taken to make exceptions the same across both interfaces - only the function names are the same. I think this makes H3CoreV3 of limited use, so I expect to remove it in an update soon after releasing h3-java v4.0.0.

@coveralls
Copy link

coveralls commented Feb 23, 2022

Pull Request Test Coverage Report for Build #269

  • 224 of 226 (99.12%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 99.38%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/uber/h3core/H3Core.java 108 109 99.08%
src/main/java/com/uber/h3core/H3CoreV3.java 91 92 98.91%
Totals Coverage Status
Change from base Build #261: 0.1%
Covered Lines: 481
Relevant Lines: 484

💛 - Coveralls

@isaacbrodsky isaacbrodsky changed the title Begin upgrading to v4.0.0-rc1 Upgrade to v4.0.0-rc2 Mar 17, 2022
@isaacbrodsky isaacbrodsky marked this pull request as ready for review March 19, 2022 00:58
@isaacbrodsky
Copy link
Collaborator Author

@dfellis @nrabinowitz @ajfriend I believe this is now ready for review.

@isaacbrodsky isaacbrodsky merged commit f628b6e into uber:master Mar 28, 2022
@isaacbrodsky isaacbrodsky deleted the bump-4.0.0-rc1 branch March 28, 2022 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants