-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to v4.0.0-rc2 #91
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
200f38c
to
93ad739
Compare
93ad739
to
08c0080
Compare
b7f68d7
to
eeda3dc
Compare
Pull Request Test Coverage Report for Build #269
💛 - Coveralls |
@dfellis @nrabinowitz @ajfriend I believe this is now ready for review. |
dfellis
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades H3-Java to H3 core library v4.0.0 release candidate. Since this is not the final v4 release, H3-Java with v4 is also considered pre-release.
A new class,
H3CoreV3
, is added to act as a compatibility layer during upgrades. Because it is implemented using the v4 library underneath, care was not taken to make exceptions the same across both interfaces - only the function names are the same. I think this makes H3CoreV3 of limited use, so I expect to remove it in an update soon after releasing h3-java v4.0.0.