Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the "test" scope for the io.grpc:grpc-testing dependency #858

Merged
merged 9 commits into from
May 2, 2024

Conversation

votez
Copy link
Contributor

@votez votez commented Sep 29, 2023

reduces runtime jar and removes unused classes from the distribution.
I.e. JUnit is not needed in prod

@coveralls
Copy link

coveralls commented Oct 24, 2023

Pull Request Test Coverage Report for Build 2193

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 60.244%

Files with Coverage Reduction New Missed Lines %
src/main/java/com/uber/cadence/internal/sync/WorkflowThreadImpl.java 1 77.2%
src/main/java/com/uber/cadence/internal/replay/ReplayDecisionTaskHandler.java 1 87.8%
src/main/java/com/uber/cadence/internal/replay/ReplayDecider.java 5 80.27%
Totals Coverage Status
Change from base Build 2191: 0.02%
Covered Lines: 11344
Relevant Lines: 18830

💛 - Coveralls

@natemort natemort self-requested a review May 1, 2024 20:07
Copy link
Contributor

@natemort natemort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, rebased.

@natemort natemort merged commit d9a7750 into uber:master May 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants