Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Model Lombok-generated equals methods as having a @Nullable p… #886

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

msridhar
Copy link
Collaborator

…arameter (#874)"

This reverts commit 5fbee1f.

It turns out that this change requires a couple of other changes along with it, including #880 and better overall checking of overriding of equals() methods. We want to get a release out soon, so temporarily revert this change; we will restore it after cutting the release.

@msridhar msridhar requested review from lazaroclapp, yuxincs and yuhsin423 and removed request for yuhsin423 December 27, 2023 00:39
@msridhar msridhar enabled auto-merge (squash) December 27, 2023 00:39
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c44ab8d) 87.18% compared to head (5473961) 87.20%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #886      +/-   ##
============================================
+ Coverage     87.18%   87.20%   +0.01%     
+ Complexity     1950     1947       -3     
============================================
  Files            77       77              
  Lines          6274     6268       -6     
  Branches       1219     1216       -3     
============================================
- Hits           5470     5466       -4     
+ Misses          405      403       -2     
  Partials        399      399              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@yuxincs yuxincs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been discussed internally, and we will re-apply this PR after we cut a release. 👍

@msridhar msridhar merged commit 1a74cd4 into uber:master Dec 27, 2023
10 checks passed
@msridhar msridhar deleted the revert-874 branch December 27, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants