Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix another bug with Lombok equals() parameter annotations #880

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fix another bug with Lombok equals() parameter annotations #880

wants to merge 9 commits into from

Commits on Dec 19, 2023

  1. Test to reproduce the issue. But it only reproduces on an earlier Err… 

    …or Prone

version.  So we need to hack dependencies.gradle, and also you need to compile
with -PepApiVersion=2.18.0 or some old version to get it to repro.

On the latest Error Prone version, 2.23.0, @SuppressWarnings("all") is better
respected, so the NullAway error goes away.
    @msridhar
    msridhar committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    1ccfab4 View commit details
    Browse the repository at this point in the history

  2. remove Gradle hack; now this failure should show up on CI

    @msridhar
    msridhar committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    5d50e8d View commit details
    Browse the repository at this point in the history

  3. Detect @SuppressWarnings("all")

    @msridhar
    msridhar committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    bad9d8a View commit details
    Browse the repository at this point in the history

  4. improve comment

    @msridhar
    msridhar committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    ddb321c View commit details
    Browse the repository at this point in the history

  5. comments

    @msridhar
    msridhar committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    d5ae980 View commit details
    Browse the repository at this point in the history

  6. undo change

    @msridhar
    msridhar committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    e3d53ba View commit details
    Browse the repository at this point in the history

  7. Revert "undo change" 

    This reverts commit e3d53ba.
    @msridhar
    msridhar committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    7091a25 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2024

  1. Merge branch 'master' into lombok-nullable-equals-subclassing

    @msridhar
    msridhar authored Jan 14, 2024
    Configuration menu
    Copy the full SHA
    210d2b6 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2024

  1. Merge branch 'master' into lombok-nullable-equals-subclassing

    @msridhar
    msridhar authored Feb 24, 2024
    Configuration menu
    Copy the full SHA
    7092ef6 View commit details
    Browse the repository at this point in the history