Skip to content

Conversation

@msridhar
Copy link
Collaborator

Fixes #1173

In JSpecify mode, we should rely on our checking of generic types and not treat @ParametricNullness as a @Nullable annotation.

@codecov
Copy link

codecov bot commented Mar 23, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.22%. Comparing base (3da2c82) to head (983051f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...away/src/main/java/com/uber/nullaway/Nullness.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1174      +/-   ##
============================================
+ Coverage     88.19%   88.22%   +0.02%     
- Complexity     2310     2311       +1     
============================================
  Files            88       88              
  Lines          7539     7541       +2     
  Branches       1508     1510       +2     
============================================
+ Hits           6649     6653       +4     
+ Misses          446      445       -1     
+ Partials        444      443       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@msridhar msridhar merged commit b84feb7 into master Mar 24, 2025
10 of 12 checks passed
@msridhar msridhar deleted the ignore-parametricnullness-in-jspecify branch March 24, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore Guava's @ParametricNullness in JSpecify mode

3 participants