This repository has been archived by the owner on Sep 25, 2020. It is now read-only.
unref() has a memory leak; don't use it #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. |
| @@ -299,5 +299,6 @@ test('emits ringpop error on canceled request', function t(assert) { | |||
| }); | |||
|
|
|||
| client.scanForWedgedRequests(); | |||
| client.destroy(); | |||
There was a problem hiding this comment.
unref'ing also wound up hiding a potentially hanging test.
|
cool. |
|
@jwolski Sorry to have lead us down this rabbit hole. And I'm a bit sad that what I thought was really responsible turned out to have evil side effects... |
jwolski
pushed a commit
that referenced
this pull request
Feb 2, 2016
unref() has a memory leak; don't use it
|
@benfleis no problemo. these things keep us on our toes! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unref'ing a setTimeout leaks memory:
Orig issue: nodejs/node-v0.x-archive#8364
Changelog: https://github.com/nodejs/node/blob/v0.10.40-release/ChangeLog#L77
@uber/ringpop @Raynos