-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add an option to disable errorVerbose #1487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
makotonakai
wants to merge
15
commits into
uber-go:master
Choose a base branch
from
makotonakai:turn-off-error-verbose
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
be8a5e3
Add opts to args of the encodeError method
makotonakai e51114b
Add DisableVerbose field to Field struct
makotonakai 9d35a43
Add DisableVerbose field to Config type
makotonakai 90f0830
Add DisableVerbose field to Logger type
makotonakai ac6d75b
Add methods to disable errorVerbose
makotonakai d3399cc
Rename DisableVerbose to DisableErrorVerbose
makotonakai 8f2d99d
Add ErrorConfig type
makotonakai 6140e33
Add ErrorTypeWithoutVerbose as a new Field type
makotonakai 50f8a40
Delete DisableErrorVerbose from Field type
makotonakai 48c1c0f
Delete disableErrorVerbose from TestErrorEncoding
makotonakai a4eff54
Add convertErrorToErrorConfig method to logger
makotonakai 8a5deac
Replace true with ec.DisableErrorVerbose
makotonakai 42b1142
Add TestErrorEncodingWithoutVerbose
makotonakai e58d348
Add errTooManyUsers
makotonakai 503e3e8
Run make lint
makotonakai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We avoid adding new struct fields to the
Field
type for performance reasons, as the struct is passed as a value.We could add a new
FieldType
to indicate an error that should only have the message included, though that could have backwards compatibility concerns with some encoders.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prashantv
I appreciate your feedback. I will create a new type with error field and DisableErrorVerbose field.