Check if EncodeLevel is set to avoid nil pointer dereference #1058
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Apologies in advance, this is my first go PR.
This PR checks if
EncodeLevel
is set before calling it onfinal
encoder clone. This prevents panic on nil pointer dereference in case it hasn't been supplied by the user. For an untrained eye, the stacktrace wasn't making it super clear thatEncodeLevel
must be provided along withLevelKey
, so hopefully an explicit check hints at it for someone reading the source code.I wasn't sure if maybe providing a sensible default here would've been better, but looking at the console logger, a similar check is made.
Thanks.