sampler: Support thereafter of zero #1033
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Zap sampling logger accepts three configuration parameters:
interval, first, and thereafter.
After we see
first
log with the same message ininterval
,the sampler kicks in.
Following that, we let through every
thereafter
-th log.So for example,
This will allow 100 logs with the same message in a second,
and following that, every 50th message with that message.
In #1032, the user wanted the sampler to reject all duplicate messages
once the limit was reached, but our sampler panics if
thereafter = 0
.This change adds support for setting
thereafter
to 0,dropping all messages in that interval once the limit is reached.
It also adds further explanation to the documentation to address the
misuse in #1032.
Resolves #1032