Fix bug for Issue: #554 MapObjectEncoder does not match jsonEncoder #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MapObjectEncoder does not match jsonEncoder (uber-go#554) Problem was that new openNamespaces that are created during AppendObject() call were not closed. Note, ONLY new openNamespaces that are created during AppendObject() are closed. If they were created at prior to AppendObject() call, it will remain open till EncodeEntry() call completes.
|
|
sammyrnycreal
changed the title
|
Hi @moisesvega @manjari25, Can I get some 👀 on this PR and have it merged in, if possible? |
|
Hi @abhinav Do you know whom I can ping to get this PR reviewed and merged in? |
|
@sammyrnycreal Thanks for the fix and apologies for the delay! Internal issue ref: GO-987 |
Codecov Report
@@ Coverage Diff @@
## master #1017 +/- ##
=======================================
Coverage 98.20% 98.21%
=======================================
Files 47 47
Lines 2064 2069 +5
=======================================
+ Hits 2027 2032 +5
Misses 29 29
Partials 8 8
Continue to review full report at Codecov.
|
abhinav
approved these changes
Nov 8, 2021
|
Thanks again, @sammyrnycreal! |
|
@abhinav Anytime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug
MapObjectEncoder does not match jsonEncoder #554
Problem was that new openNamespaces that are created during AppendObject() call were not closed.
Note, ONLY new openNamespaces that are created during AppendObject() are closed. If they were created at prior to AppendObject() call, it will remain open till EncodeEntry() call completes.
make allpasses all test.@jkanywhere This will resolve the issue you raised. I included the test you wrote up here Thank you, that helped me find the bug.