Skip to content

panic: fix nil pointer dereference when x is a nil pointer #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

panic: fix nil pointer dereference when x is a nil pointer #253

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1fe370
fix nil pointer dereference panic when x is a nil pointer
agbaria May 4, 2025
ffcef96
ValueOf instead of TypeOf
agbaria May 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions gomock/string.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ func getString(x any) string {
if isGeneratedMock(x) {
return fmt.Sprintf("%T", x)
}
typ := reflect.TypeOf(x)
if typ.Kind() == reflect.Ptr && typ.IsNil() {
return "nil"
}
if s, ok := x.(fmt.Stringer); ok {
return s.String()
}
Expand Down