add support for generics in reflect mode #136
Conversation
|
|
MartinForReal
changed the title
|
@r-hang PTAL. Thanks! |
|
Does your implementation work for cases like
|
|
also see: #97 |
| if typeName := t.Name(); strings.ContainsAny(typeName, "[]") { | ||
| var ts []Type | ||
| startIndex := strings.Index(typeName, "[") | ||
| endIndex := strings.Index(typeName, "]") |
There was a problem hiding this comment.
Golang's type parameter can be a slice X[] or another type parameter, therefore, I am afraid the assumption here for unwrapping [] is incorrect giving case like foo.bar[baz[]].
FWIW, since golang's reflection doesn't provide the type parameter details, we don't have a good way to tell what is the concrete type used. One way I was attempting to use is to use a recursive parser to extract the nested type parameters, but not that simple to write right... Another way is to wait for support from reflect...
Another workaround is to use source mode instead of reflect mode...
There was a problem hiding this comment.
I'll try the recursive parser. Thanks for the hint!
Parse TypeParameters from type name only when "[]" is present in type name.
related: #128