Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct cargo install command #21

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Correct cargo install command #21

merged 1 commit into from
Jan 26, 2024

Conversation

nuke-web3
Copy link
Contributor

Seems there are a few more installable crates in the repo than just the lsp, so you need to be explicit :)

Seems there are a few more installable crates in the repo than just the lsp, so you need to be explicit :)
@nuke-web3
Copy link
Contributor Author

nuke-web3 commented Jan 25, 2024

I also noticed in helix-editor/helix#7474 that no wiki on this existed yet, so made one https://github.com/helix-editor/helix/wiki/How-to-install-the-default-language-servers#typst - anything further that should be mentioned there? I see that https://github.com/uben0/tree-sitter-typst#helix is no longer needed, as helix has the right config automagically from that PR now (on yet to be released master there)

Perhaps a note about https://github.com/nvarner/typst-lsp/tree/master/editors/lapce that I assume you should use over the main crate if using https://lapce.dev/ but I don't use that editor to test the install and config 😓

@uben0 uben0 merged commit 57068e6 into uben0:master Jan 26, 2024
@uben0
Copy link
Owner

uben0 commented Jan 26, 2024

no longer needed, as helix has the right config

Yes... But no. Because the PR has a quite old commit (ecf8596) it will leverage an outdated version. A PR to update the version is welcome but as I plan to bring important modifications to the grammar #19 I wait to complete those change before making a new PR. Especially because, those modifications should fix an important bug #17

But still, once the new release of Helix is out, I can change the installation instructions, indicating it is only to benefit from an up to date grammar.

@uben0
Copy link
Owner

uben0 commented Jan 26, 2024

Oh... wait no actually. Someone already updated the commit hash. The ecf8596 commit is very recent. That's great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants