Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rounding from processor count statistic classes #25

Merged
merged 1 commit into from
Jan 17, 2017

Conversation

jtpalmer
Copy link
Contributor

Description

Removes use of the CEIL function in SQL for processor count statistics.

Motivation and Context

The average processor count values are displayed as decimals in the chart tooltips (as well as value labels, etc.). This would imply that the precision of these numbers is higher than what is being returned from the data warehouse. While the maximum and minimum processor counts are expected to be integers, it is reasonable to have non-integer (average) job size (core counts).

Tests performed

Viewed usage tab charts for the altered statistics and observed the now non-integer values.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Processor count statistics are no longer rounded up to the nearest integer.
@jtpalmer jtpalmer added the bug Bugfixes label Jan 13, 2017
@jtpalmer jtpalmer added this to the v6.6.0 milestone Jan 13, 2017
@jtpalmer jtpalmer merged commit 97c839d into ubccr:xdmod6.6 Jan 17, 2017
@jtpalmer jtpalmer deleted the remove-statistic-rounding branch January 18, 2017 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugfixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants