Move MariaDB configuration guide section to the top. #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronweeden
force-pushed
the
update-configuration-guide
branch
from
06c501b
to
df44dcd
Compare
aaronweeden
requested review from
eiffel777,
jpwhite4,
ryanrath,
connersaeli and
aestoltm
ryanrath
previously approved these changes
Sep 6, 2024
aestoltm
reviewed
Sep 6, 2024
There was a problem hiding this comment.
Do we want to move the section about the database configuration up to the top or do we still want it where it currently is in configuration.md? Would it be beneficial to have this entire part towards the top?
[mysqld]
sql_mode = ''
max_allowed_packet = 1G
group_concat_max_len = 16M
innodb_stats_on_metadata = off
innodb_file_per_table = On
jpwhite4
reviewed
Sep 6, 2024
aaronweeden
force-pushed
the
update-configuration-guide
branch
from
6aa160c
to
c995af7
Compare
aaronweeden
changed the title
sql_mode setting earlier in configuration guide.
aaronweeden
force-pushed
the
update-configuration-guide
branch
from
8526ff6
to
a29c001
Compare
connersaeli
reviewed
Oct 17, 2024
| server system variable must be changed to 16MB from its default value of 1024 | ||
| bytes. | ||
|
|
||
| The `max_allowed_packet` setting must be set to at least 16MB. |
There was a problem hiding this comment.
Is this supposed to be the same as max_allowed_packet = 1G below? Or is 16MB a minimum with the actual set to 1GB?
There was a problem hiding this comment.
Not sure, it's been that way since #1157
aaronweeden
force-pushed
the
update-configuration-guide
branch
from
a29c001
to
d5a01b1
Compare
ryanrath
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates https://open.xdmod.org/configuration.html to move the MariaDB section to the top since it needs to be running before running
xdmod-setup. This is a common gotcha about which we have gotten a number of tickets.Checklist: