Ensure dashboard is updated whenever reports change. #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the daashboard was only updated when a report was deleted. This change moves the request_refresh call to the callback for the report generator report store. This ensures that whenever the store is updated (chart add, deletes and edits) then the dashboard will be updated. Tested manually by adding, renaming and deleting reports and switching back to the dashboard to confirm that it reloads. I also confirmed that the dashboard does NOT reload when you just view a report and don't edit it.
jtpalmer
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the daashboard was only updated when a report was deleted.
This change moves the request_refresh call to the callback for the
report generator report store. This ensures that whenever the store
is updated (chart add, deletes and edits) then the dashboard will
be updated.
Tested manually by adding, renaming and deleting reports and switching
back to the dashboard to confirm that it reloads. I also confirmed that the
dashboard does NOT reload when you just view a report and don't edit it.
This issue was observed in asana ticket https://app.asana.com/0/808093868887967/1141900082957794