Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing attributes when gearing over from Usage to Metric #1506

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

jpwhite4
Copy link
Member

@jpwhite4 jpwhite4 commented Mar 9, 2021

This fixes an issue with adding data to charts that were originally configured by "gearing over" from the Usage tab.

Steps to reproduce the original problem:

  1. View a chart in the Usage tab
  2. Gear over to load the chart in the Metric Explorer
  3. Add data for a different realm to the chart
  4. The Realm label should appear as a prefix for the dataset labels for each dataset. But is is missing for the first dataset.

For the original bug report see:

See https://app.asana.com/0/808093868887967/1184327725706337

Note the bug is fixed by the one line that populates the category object property. However, in investigating the bug there were several other configuration keys that were not defined. This change also ensures that all the required properties are given a value.

@jpwhite4 jpwhite4 added the bug Bugfixes label Mar 9, 2021
@jpwhite4 jpwhite4 added this to the 9.5.0 milestone Mar 9, 2021
@jpwhite4
Copy link
Member Author

jpwhite4 commented Mar 9, 2021

Before:
image

After:
image

@jpwhite4 jpwhite4 marked this pull request as ready for review March 9, 2021 20:51
Copy link
Contributor

@jsperhac jsperhac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Joe. Thanks for fixing!

@jpwhite4 jpwhite4 merged commit df06fc0 into ubccr:xdmod9.5 Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugfixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants