Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the logging code to not throw away all class information #1493

Merged
merged 2 commits into from
Feb 10, 2021

Commits on Feb 8, 2021

  1. Updating the logging code to not throw away all class information

    We ran into a problem described in this PR:
    ubccr#1490 After some research I found that the
    root of the problem is this function json_encode'ing `$record` when the contents
    of `$record` may contain objects that do not support `JsonSerializable` but that
    do implement `toString()`. After a conversation w/ Joe it's been decided that
    our Logging API will be to support the logging of arrays w/ objects that
    implement a `toString()` function. The eagle-eyed may notice that this solution
    differs from the one I put forth in the above PR. The reason being that the
    original solution only supported the use case of having an array w/ top level
    value objects and would not work as expected if a nested array is supplied with
    an object that implements `toString()`.
    Ryan Rathsam committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    dd1fbe7 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. Adding Additional Documentation

    Per @jpwhite4, it's important that we document that our Logger supports logging
    both strings and arrays, and if an array is provided that contains objects,
    those objects will be converted to strings via the `__toString` function.
    Ryan Rathsam committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    f30bdc6 View commit details
    Browse the repository at this point in the history