Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-index filtered arrays #1481

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Re-index filtered arrays #1481

merged 1 commit into from
Jan 11, 2021

Conversation

jtpalmer
Copy link
Contributor

Description

Use array_values to re-index returned arrays.

Motivation and Context

These arrays are created using array_filter and that may produce gaps in numeric array keys.

Tests performed

No new tests.

Checklist:

  • The pull request description is suitable for a Changelog entry
  • The milestone is set correctly on the pull request
  • The appropriate labels have been added to the pull request

@jtpalmer jtpalmer added bug Bugfixes Category:General General labels Jan 11, 2021
@jtpalmer jtpalmer added this to the 9.5.0 milestone Jan 11, 2021
@jtpalmer jtpalmer mentioned this pull request Jan 11, 2021
Merged
6 tasks
jsperhac
jsperhac approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@jsperhac jsperhac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Jeff. Thanks for responding so quickly with this fix.

@jtpalmer jtpalmer merged commit ba81907 into ubccr:xdmod9.5 Jan 11, 2021
@jtpalmer jtpalmer deleted the fix-filtered-indexes branch January 11, 2021 17:39
@jtpalmer jtpalmer changed the title Fix filtered indexes Re-index filtered arrays Jan 11, 2021
jtpalmer added a commit to jtpalmer/xdmod that referenced this pull request Jan 12, 2021
@jtpalmer
Fix indexes of array return values (ubccr#1481)
c6ef46c
@jsperhac jsperhac mentioned this pull request Jan 15, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsperhac jsperhac jsperhac approved these changes

Assignees
No one assigned
Labels
bug Bugfixes Category:General General
Projects
None yet
Milestone
9.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jtpalmer @jsperhac