Make cloud realm compatible with ONLY_FULL_GROUP_BY #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpwhite4
reviewed
Jan 14, 2021
configuration/etl/etl_action_defs.d/cloud_common/cloud_resource_specs_aggregation.json
Show resolved
Hide resolved
jpwhite4
requested changes
Feb 23, 2021
| @@ -0,0 +1,33 @@ | |||
| <?php | |||
| namespace OpenXdmod\Migration\Version851To900; | |||
There was a problem hiding this comment.
Wrong namespace - also this change conflicts with the other cloud resources pull request.
ryanrath
reviewed
Feb 24, 2021
jpwhite4
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes makes changes so the cloud realm is compatible with MySQL when ONLY_FULL_GROUP_BY mode is enabled.
For the cloud aggregation the entails adding columns to the group by for the aggregation query. For the cloud resource specifications aggregation it revealed a bug when summing the core time for a time period because of a misplaced parenthesis. Re-aggregation of the cloud resource specifications is necessary because of this.
Checklist: