-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide dashboard reports from Report Generator #1445
Conversation
97d65ec
to
7ad9098
Compare
7ad9098
to
210807a
Compare
210807a
to
1846093
Compare
@@ -1034,8 +1034,8 @@ class ReportGenerator { | |||
browser.waitForVisible(this.selectors.myReports.toolbar.downloadAsPdfButton()); | |||
browser.click(this.selectors.myReports.toolbar.downloadAsPdfButton()); | |||
// Wait for check mark image to appear and disappear. | |||
browser.waitForVisible(this.selectors.checkmarkMask(), 10000); | |||
browser.waitForInvisible(this.selectors.checkmarkMask(), 10000); | |||
browser.waitForVisible(this.selectors.checkmarkMask(), 60000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Timings on a "fresh" install in my local docker (27.27, 8.11, 6.65, 11.52)
How have you tested this to confirm that the dashboard reports are still working? |
modifying metrics-dev and logging in as a center director and normal user. and of course in the docker |
The dashboard tab reports are special templates that are not meant to have reports generated from them. This hides them from the report generator drop down.