Switch to Chromium instead of PhantomJS to generate chart export images. #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plessbd
changed the title
plessbd
force-pushed
the
minus-phantomjs
branch
2 times, most recently
from
baec500
to
26246dd
Compare
plessbd
added
Category:Infrastructure
jpwhite4
reviewed
Aug 10, 2020
jpwhite4
reviewed
Aug 10, 2020
jpwhite4
reviewed
Aug 10, 2020
plessbd
force-pushed
the
minus-phantomjs
branch
from
26246dd
to
962978d
Compare
jpwhite4
reviewed
Aug 10, 2020
plessbd
changed the title
plessbd
force-pushed
the
minus-phantomjs
branch
from
0d38008
to
8e2853e
Compare
plessbd
force-pushed
the
minus-phantomjs
branch
5 times, most recently
from
f17709e
to
08f7076
Compare
plessbd
force-pushed
the
minus-phantomjs
branch
from
08f7076
to
c380e3c
Compare
jpwhite4
changed the title
|
Please can you add some info to the upgrade.md to explain that the dependencies have changed. |
plessbd
force-pushed
the
minus-phantomjs
branch
from
c20eeb3
to
8f3703e
Compare
plessbd
force-pushed
the
minus-phantomjs
branch
from
8f3703e
to
9b923a1
Compare
jpwhite4
reviewed
Aug 19, 2020
jpwhite4
requested changes
Aug 19, 2020
plessbd
force-pushed
the
minus-phantomjs
branch
from
0e36a6b
to
d097a2e
Compare
plessbd
force-pushed
the
minus-phantomjs
branch
from
d097a2e
to
608c091
Compare
jpwhite4
approved these changes
Aug 19, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression tests will be updated as the font rendering in PhantomJS vs Chrome changes a bunch of things.
Motivation:
PhantomJS is not supported.
Chromium was chosen as there is a package specially for chromeium_headless in EPEL.
This IN THEORY will work with any properly installed and configured chrome, but has NOT been tested.