Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CI validate script #1399

Merged
merged 1 commit into from
Jul 25, 2020
Merged

Improve CI validate script #1399

merged 1 commit into from
Jul 25, 2020

Conversation

jtpalmer
Copy link
Contributor

Description

Quotes variables used in the shell script and use bash [[ for comparisons. Also fixes a typo.

Motivation and Context

If tables don't exist then an additional error message is produced:

./tests/ci/validate.sh: line 25: [: -ne: unary operator expected

Tests performed

Tested manually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jtpalmer jtpalmer added bug Bugfixes qa / testing Updates/additions to tests Category:General General labels Jul 24, 2020
@jtpalmer jtpalmer requested a review from jpwhite4 July 24, 2020 16:56
@jtpalmer jtpalmer merged commit c0ceb4e into ubccr:xdmod9.0 Jul 25, 2020
@jtpalmer jtpalmer deleted the improve-validate branch July 25, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plessbd plessbd plessbd approved these changes

@jpwhite4 jpwhite4 jpwhite4 approved these changes

Assignees
No one assigned
Labels
bug Bugfixes Category:General General qa / testing Updates/additions to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtpalmer @plessbd @jpwhite4