Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node utilization documentation #1397

Merged
merged 4 commits into from
Jul 23, 2020
Merged

Conversation

jtpalmer
Copy link
Contributor

@jtpalmer jtpalmer commented Jul 23, 2020

Description

Updates the node utilization documentation with instructions on how to add the statistic.

Motivation and Context

The node utilization statistic is not enabled by default and this result in it's removal during the group by refactoring.

https://app.asana.com/0/342819846538629/1185671232325737/f

Tests performed

Tested instructions manually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jtpalmer jtpalmer added documentation Documentation updates Category:General General labels Jul 23, 2020
@jtpalmer jtpalmer added this to the 9.0.0 milestone Jul 23, 2020
@plessbd
Copy link
Contributor

plessbd commented Jul 23, 2020

Thank you for doing this, should we make this more "generic" at some point as a "How to add additional metrics"

Just an idea.

Copy link
Contributor

@plessbd plessbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add something about doing a touch on a file inside /etc/xdmod/datawarehouse.d/ or restarting the web server.
Otherwise APC wont pick up the change

@jtpalmer
Copy link
Contributor Author

@plessbd are you sure about that? I tested the instructions and didn't need to do that.

@jtpalmer
Copy link
Contributor Author

@plessbd I updated the instructions.

@jtpalmer jtpalmer merged commit 4ef28b7 into ubccr:xdmod9.0 Jul 23, 2020
@jtpalmer jtpalmer deleted the node-util-docs branch July 23, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:General General documentation Documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants