Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use piped logging to rotate Apache logs #1371

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

jtpalmer
Copy link
Contributor

Description

Replace Apache log rotation using logrotate with rotatelogs.

Motivation and Context

https://app.asana.com/0/342819846538629/1182411629511737/f

Tests performed

Tested manually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jtpalmer jtpalmer added bug Bugfixes Category:General General labels Jul 10, 2020
@jtpalmer jtpalmer added this to the 9.0.0 milestone Jul 10, 2020
@jtpalmer jtpalmer requested a review from jpwhite4 July 10, 2020 18:31
@jtpalmer jtpalmer requested a review from ryanrath July 10, 2020 18:59
@jtpalmer
Copy link
Contributor Author

I just picked an arbitrary number of files and size limit, so if anyone has an opinion about the defaults, we can change those.

Copy link
Contributor

@ryanrath ryanrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's just important that the size is capped. As far as size goes, 1MB seems a sensible default to use until we hear / experience otherwise.

@jtpalmer jtpalmer merged commit 8178282 into ubccr:xdmod9.0 Jul 13, 2020
@jtpalmer jtpalmer deleted the apache-logs-2020-0003 branch July 13, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugfixes Category:General General
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants