Remove jasper reports and replace with PHPWord/libreoffice #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpwhite4
added
Category:Report Generator
jpwhite4
force-pushed
the
reports
branch
2 times, most recently
from
d721bdc
to
f824192
Compare
plessbd
changed the title
6 tasks
plessbd
suggested changes
Aug 14, 2020
| @@ -15,7 +15,7 @@ Requires: httpd | |||
| Requires: mariadb >= 5.5.3 | |||
| Requires: php >= 5.4 php-cli php-mysql php-pdo php-gd php-xml php-mbstring | |||
| Requires: php-pear-MDB2 php-pear-MDB2-Driver-mysql php-pecl-apcu | |||
| Requires: java-1.8.0-openjdk java-1.8.0-openjdk-devel | |||
| Requires: libreoffice | |||
There was a problem hiding this comment.
change to libreoffice-writer
as per bpless code review. (this saves about 15 MB on the image size).
plessbd
approved these changes
Oct 16, 2020
3 tasks
jpwhite4
added
dependencies
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch to using PHPWord to generate the reports. This outputs reliably in Word doc format, but the pdf format is lacking so LibreOffice is used to generate the pdf outputs.
This change attempts to produce visually identical reports as before, although the internal file layout is changed. The Jasper reports stuff used one giant table per page. This causes word to report errors when trying to print the report and also causes problems with chart images being truncated when there are long subtitle strings. This version uses the header and footer of the doc (the Jasper reports just has a table row at the top and one at the bottom). The layout is done using paragraph styles so the output word doc is actually easily editable.
The report generation for word docs is significantly faster on my docker instance. The pdf export seems to be about the same.
Motivation
This backend should give us the flexibility to easily produce advanced reports that include tabular information and are not just limited to 1/2 charts per page.
The hardcoded layout stuff is all in the
Reports/ClassicReport.phpclass. The idea would be to keep this around for the time being then deprecate it when we have the improved reporting infrastructure,